feat(storage): support IAM authentication for S3 storage#358
Merged
dongmucat merged 1 commit intoiflytek:mainfrom Apr 29, 2026
Merged
feat(storage): support IAM authentication for S3 storage#358dongmucat merged 1 commit intoiflytek:mainfrom
dongmucat merged 1 commit intoiflytek:mainfrom
Conversation
When access-key / secret-key are left blank, fall back to the AWS DefaultCredentialsProvider chain so that deployments on EC2, ECS, and EKS can authenticate via instance profile, task role, or IRSA without static credentials. - Extract buildCredentialsProvider() in S3StorageService - Add sts dependency for Web Identity Token (EKS) support - Add unit tests for credential provider selection - Update storage-spi docs (zh + en) and env example
dongmucat
approved these changes
Apr 29, 2026
Collaborator
dongmucat
left a comment
There was a problem hiding this comment.
LGTM,感谢这个 PR!
OIDC 接入的设计很干净:复用现有 OAuth2 的准入、绑定和会话链路,不需要新表、不改前端,claims 映射逻辑清晰,测试覆盖也到位。文档中英文同步更新、registration ID 冲突警告这些细节都考虑到了,很用心。
可以合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Validation
Commands run:
```bash
Unit tests
docker run --rm -v ./server:/workspace -w /workspace maven:3.9-eclipse-temurin-21
mvn test -pl skillhub-storage -am --batch-mode
Full compile
docker run --rm -v ./server:/workspace -w /workspace maven:3.9-eclipse-temurin-21
mvn compile -pl skillhub-app -am --batch-mode
```
Risk
Notes